Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use --force to install eslint v9 + tseslint #118

Merged
merged 1 commit into from
May 26, 2024

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented May 18, 2024

it does not suppport eslint v9 yet.
refs: #89 (comment)
fixes #120

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label May 18, 2024
it does not suppport eslint v9 yet.
refs: #89 (comment)
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic
Copy link
Member

Merging now as an important fix to get into a patch release.

@mdjermanovic mdjermanovic merged commit 27a207e into main May 26, 2024
19 checks passed
@mdjermanovic mdjermanovic deleted the fix/tseslint+eslint-v9 branch May 26, 2024 12:44
@github-actions github-actions bot mentioned this pull request May 26, 2024
@illBeRoy
Copy link

Hey guys,
this change broke yarn compatibility with the following error:

image

Also, it seems like the --force flag is added even when selecting eslint v8 (which is the case here).

If that's ok, I'll look into pushing a fix later today or tomorrow.

@aladdin-add
Copy link
Member Author

there is a report #122, and I have made a fix: #123. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: ESLint config cli fails - eslint@9.3.0 vs 8.56.0
3 participants