Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/docs/data architecture #424

Merged
merged 4 commits into from
May 30, 2024

Conversation

LouisVdwl
Copy link
Contributor

Issue link / number:

#423

What changes did you make?

  • Add database schema section in data-architecture.md
  • Change the database models image in data-architecture.md

Why did you make the changes?

Asked in the issue #423

Copy link
Member

@kyleecodes kyleecodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey great work @LouisVdwl! One small change I suggest -- can you move the photos to the /docs directory? Then we'll merge ASAP. Thanks!

@LouisVdwl
Copy link
Contributor Author

LouisVdwl commented May 28, 2024

Hey great work @LouisVdwl! One small change I suggest -- can you move the photos to the /docs directory? Then we'll merge ASAP. Thanks!

Hey @kyleecodes, I updated the PR. Thanks for your feedback !

Copy link
Member

@kyleecodes kyleecodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyleecodes kyleecodes merged commit 5bf1f56 into chaynHQ:develop May 30, 2024
2 checks passed
@LouisVdwl LouisVdwl deleted the update/docs/data-architecture branch May 31, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants