Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calibrite-profiler #174161

Merged
merged 1 commit into from
May 18, 2024
Merged

Add calibrite-profiler #174161

merged 1 commit into from
May 18, 2024

Conversation

MTCoster
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully. See below
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

This app isn't open source - it just uses GitHub releases for asset hosting. The latest stable release as per the download page and release notes is the current "pre-release" as marked on GitHub. Add to github_prerelease_allowlist to ignore the lint.

The brew audit --cask --new check fails with two issues:

 - Upstream defined :high_sierra as the minimum OS version and the cask defined :catalina
 - GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars)

The first is a conflict between Info.plist (which says High Sierra 10.13) and the vendor website (which says Catalina 10.15). The second is the same GitHub issue as the pre-release above, but with no obvious equivalent allowlist to exempt it.

This cask previously existed in cask-drivers as calibrite-ccprofiler - it was renamed at some point and never updated, then removed completely during the migration back to cask due to lack of use.

Copy link
Member

@bevanjkay bevanjkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MTCoster - I have left some comments in my review.

Casks/c/calibrite-profiler.rb Outdated Show resolved Hide resolved
Casks/c/calibrite-profiler.rb Outdated Show resolved Hide resolved
Casks/c/calibrite-profiler.rb Outdated Show resolved Hide resolved
@bevanjkay bevanjkay added the ci-skip-repository Skip repository checks on CI. Use only after repository has been verified manually. label May 17, 2024
@miccal miccal added the awaiting user reply Issue needs response from a user. label May 18, 2024
@MTCoster
Copy link
Contributor Author

Thanks for the review @bevanjkay – I’ve made the suggested changes

Copy link
Member

@bevanjkay bevanjkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MTCoster Sorry, I realised I forgot one more small change

Casks/c/calibrite-profiler.rb Outdated Show resolved Hide resolved
This app isn't open source - it just uses GitHub releases for asset
hosting. The latest stable release as per the download page and release
notes is the current "pre-release" as marked on GitHub. Add to
github_prerelease_allowlist to ignore the lint.
@krehel krehel merged commit 9d373ba into Homebrew:master May 18, 2024
9 checks passed
@MTCoster MTCoster deleted the calibrite-profiler branch May 18, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip awaiting user reply Issue needs response from a user. ci-skip-repository Skip repository checks on CI. Use only after repository has been verified manually.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants