Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wd-security 2.1.2.144 (new cask) #173945

Closed
wants to merge 6 commits into from
Closed

Conversation

unitof
Copy link
Contributor

@unitof unitof commented May 16, 2024

Obscure and kinda dusty app, but used by the very popular Backblaze software for their mailed restore drives

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@bevanjkay
Copy link
Member

/rebase

@unitof
Copy link
Contributor Author

unitof commented May 18, 2024

The installer prompts for macOS user password in an "app wants to make changes" dialog. Running with sudo still requests it.

Any way to handle this for the TestBot?

@bevanjkay
Copy link
Member

@unitof Casks shouldn't require user intervention outside of entering your password in terminal for sudo when required.

So unfortunately this is a blocking issue.
I'm not sure a way to resolve it unless there's an alternative installation method.

unitof and others added 2 commits May 20, 2024 00:34
The Gatekeeper prompt is slightly different in my testing (TouchID instead of password prompt) so may pass tests
@bevanjkay
Copy link
Member

@unitof We're close here now

Error: Some launch jobs were not unloaded, add them to uninstall launchctl:
com.wdc.WDPrivilegedHelper

@unitof
Copy link
Contributor Author

unitof commented May 20, 2024

Huh. Any other approaches or places I should look for more info?

@bevanjkay
Copy link
Member

It may not be being removed because it is still running, so what I tried may not be actually closing it.

@bevanjkay
Copy link
Member

Hey @unitof - thanks for working on this, but it seems like although we are using sudo for the installer script it still pops another prompt that requires user intervention. As this a blocker, and the cask is "obscure" as you have mentioned, I think it's best if you pop this in your own tap.

@bevanjkay bevanjkay closed this May 20, 2024
unitof added a commit to unitof/homebrew-formulae that referenced this pull request May 20, 2024
Will maintain here, since cask permissions are too weird for official cask

Homebrew/homebrew-cask#173945
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants